linux-kernel - Re: [PATCH] io_uring: fix uninit-value in io_sendrecv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 16 Mar 2024 07:11:20 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Edward Adam Davis <eadavis@...com>,
 syzbot+f8e9a371388aa62ecab4@...kaller.appspotmail.com
Cc: asml.silence@...il.com, io-uring@...r.kernel.org,
 linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] io_uring: fix uninit-value in io_sendrecv_fail

On 3/16/24 6:42 AM, Edward Adam Davis wrote:
> diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
> index cd9a137ad6ce..3db59fd6f676 100644
> --- a/io_uring/io_uring.c
> +++ b/io_uring/io_uring.c
> @@ -1066,6 +1066,7 @@ static void io_preinit_req(struct io_kiocb *req, struct io_ring_ctx *ctx)
>  	/* not necessary, but safer to zero */
>  	memset(&req->cqe, 0, sizeof(req->cqe));
>  	memset(&req->big_cqe, 0, sizeof(req->big_cqe));
> +	memset(&req->cmd, 0, sizeof(req->cmd));
>  }
>  
>  static void io_flush_cached_locked_reqs(struct io_ring_ctx *ctx,

This will just silence the syzbot report, as the memory is initialized
upfront. But it's not the real fix, as ->done_io could still be recycled
from a previous issue.

-- 
Jens Axboe