[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240316001251.l3ifu5exkrjmbhoe@begin>
Date: Sat, 16 Mar 2024 01:12:52 +0100
From: Samuel Thibault <samuel.thibault@...-lyon.org>
To: Helge Deller <deller@....de>
Cc: linux-kernel@...r.kernel.org, Daniel Vetter <daniel@...ll.ch>,
Alexey Gladkov <legion@...nel.org>,
Jiry Slaby <jirislaby@...nel.org>, linux-fbdev@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] fbcon: Increase maximum font width x height to 64 x 64
Hello,
Helge Deller, le ven. 15 mars 2024 10:35:40 +0100, a ecrit:
> You should have marked this patch with "v2"...
The actual changes were exactly the same.
> On 3/13/24 17:59, Samuel Thibault wrote:
> > This remains relatively simple by just enlarging integers.
>
> I like the patch, but I still see some u32...
> drivers/video/fbdev/vt8623fb.c: info->pixmap.blit_x = (bpp == 4) ? (1 << (8 - 1)) : (~(u32)0);
> drivers/video/fbdev/arkfb.c: info->pixmap.blit_x = (bpp == 4) ? (1 << (8 - 1)) : (~(u32)0);
> drivers/video/fbdev/core/fbmem.c: fb_info->pixmap.blit_x = ~(u32)0;
> drivers/video/fbdev/s3fb.c: info->pixmap.blit_x = (bpp == 4) ? (1 << (8 - 1)) : (~(u32)0);
Oops, I missed including these modifications indeed.
> > It wouldn't be that simple to get to the console's 64x128 maximum, as it would
> > require 128b integers.
>
> How realistic are fonts > 64x64 pixels ?
With 4K displays, 64x128 brings 60x16 text console, which is useful for
people with low vision.
> If they are, using the bitmap_xx functions (include/linux/bitmap.h)
> now instead would be better.
Ok, I have now done this in v2. We'll be able to easily increase the
font size when 8K displays get out :)
Samuel
Powered by blists - more mailing lists