linux-kernel - Re: [PATCH 0/2] media: i2c: Add support for GC05A2 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4512301c8514bd758eebb166bbed44f2ac65e5f.camel@mediatek.com>
Date: Sat, 16 Mar 2024 03:03:51 +0000
From: Zhi Mao (毛智) <zhi.mao@...iatek.com>
To: "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>
CC: "heiko@...ech.de" <heiko@...ech.de>, "tomi.valkeinen@...asonboard.com"
	<tomi.valkeinen@...asonboard.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>,
	"yunkec@...omium.org" <yunkec@...omium.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "dan.scally@...asonboard.com"
	<dan.scally@...asonboard.com>, "gerald.loacker@...fvision.net"
	<gerald.loacker@...fvision.net>,
	Shengnan Wang (王圣男)
	<shengnan.wang@...iatek.com>, "hdegoede@...hat.com" <hdegoede@...hat.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
	Yaya Chang (張雅清) <Yaya.Chang@...iatek.com>,
	"mchehab@...nel.org" <mchehab@...nel.org>, "jacopo.mondi@...asonboard.com"
	<jacopo.mondi@...asonboard.com>, "jernej.skrabec@...il.com"
	<jernej.skrabec@...il.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "bingbu.cao@...el.com"
	<bingbu.cao@...el.com>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
	"10572168@...com" <10572168@...com>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>, "macromorgan@...mail.com"
	<macromorgan@...mail.com>
Subject: Re: [PATCH 0/2] media: i2c: Add support for GC05A2 sensor

Hi Andy,

Thanks for your review.


On Wed, 2024-03-13 at 10:52 +0200, Andy Shevchenko wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Wed, Mar 13, 2024 at 7:54 AM Zhi Mao <zhi.mao@...iatek.com>
> wrote:
> >
> > This series adds YAML DT binding and V4L2 sub-device driver for
> Galaxycore's
> > GC05A2 5-megapixel 10-bit RAW CMOS 1/5" sensor, with an MIPI CSI-2
> image data
> > interface and the I2C control bus.
> >
> > The driver is implemented with V4L2 framework.
> >  - Async registered as a V4L2 sub-device.
> >  - As the first component of camera system including Seninf, ISP
> pipeline.
> >  - A media entity that provides one source pad in common.
> >  - Used in camera features on ChromeOS application.
> >
> > Also this driver supports following features:
> >  - manual exposure and analog gain control support
> >  - vertical blanking control support
> >  - test pattern support
> >  - media controller support
> >  - runtime PM support
> >  - support resolution: 2592x1944@...ps, 1280x720@...ps
> 
> Not even going to do a thorough review as one should learn on the
> previous reviews. Most of the comments that I had given to another
> driver submission are applicable here. So, waiting for v2 with all
> applicable being addressed.
> 

The comments are fixed in patch:v1

https://lore.kernel.org/linux-media/20240316025253.2300-1-zhi.mao@mediatek.com/
> -- 
> With Best Regards,
> Andy Shevchenko