[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3ae535cf-9a89-4187-a761-8390d649b00b@salutedevices.com>
Date: Sun, 17 Mar 2024 18:19:36 +0300
From: Jan Dakinevich <jan.dakinevich@...utedevices.com>
To: Mark Brown <broonie@...nel.org>
CC: Neil Armstrong <neil.armstrong@...aro.org>, Jerome Brunet
<jbrunet@...libre.com>, Michael Turquette <mturquette@...libre.com>, Stephen
Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>, Kevin Hilman <khilman@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Liam Girdwood
<lgirdwood@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Jaroslav
Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
<linux-amlogic@...ts.infradead.org>, <linux-clk@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <alsa-devel@...a-project.org>,
<linux-sound@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
<kernel@...utedevices.com>
Subject: Re: [PATCH 09/25] ASoC: meson: g12a-toacodec: add support for A1 SoC
family
On 3/15/24 16:33, Mark Brown wrote:
> On Fri, Mar 15, 2024 at 02:21:45AM +0300, Jan Dakinevich wrote:
>
>> static const struct regmap_config g12a_toacodec_regmap_cfg = {
>> - .reg_bits = 32,
>> - .val_bits = 32,
>> - .reg_stride = 4,
>> + .reg_bits = 32,
>> + .val_bits = 32,
>> + .reg_stride = 4,
>> + .max_register = TOACODEC_CTRL0,
>> + .max_register_is_0 = true,
>
> If the maximum register is 0 how does the regmap have a stride?
reg_stride inherited from existing code. Apparently, it was meaningless
even before my modifications (the hardware has single register
regardless of max_register declaration) and it should be dropped. But,
is it okay to remove it in the same commit?
--
Best regards
Jan Dakinevich
Powered by blists - more mailing lists