linux-kernel - Re: [PATCH v4 0/6] Add support i.MX95 BLK CTL module clock features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240317155911.pdc32nsyxcdhs2t7@pengutronix.de>
Date: Sun, 17 Mar 2024 16:59:11 +0100
From: Marco Felsch <m.felsch@...gutronix.de>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: Abel Vesa <abelvesa@...nel.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, imx@...ts.linux.dev,
	Peng Fan <peng.fan@....com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 0/6] Add support i.MX95 BLK CTL module clock features

Hi Peng,

thank for the patchset.

On 24-03-14, Peng Fan (OSS) wrote:
> i.MX95's several MIXes has BLK CTL module which could be used for
> clk settings, QoS settings, Misc settings for a MIX. This patchset
> is to add the clk feature support, including dt-bindings

I have to ask since there is almost no public documentation available
yet. The i.MX95 does have an system-controller for managing pinmux
settings and power-domains, right? If this is the case, why not making
use of it via the standard scmi_pm_domain.c driver?

Regards,
  Marco



> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> Changes in v4:
> - Separate binding doc for each modules, I still keep the syscon as node
> name, because the module is not just for clock
> - Pass dt-schema check
> - Update node compatibles
> - Link to v3: https://lore.kernel.org/r/20240228-imx95-blk-ctl-v3-0-40ceba01a211@nxp.com
> 
> Changes in v3:
> - Correct example node compatible string
> - Pass "make ARCH=arm64 DT_CHECKER_FLAGS=-m -j32 dt_binding_check"
> - Link to v2: https://lore.kernel.org/r/20240228-imx95-blk-ctl-v2-0-ffb7eefb6dcd@nxp.com
> 
> Changes in v2:
> - Correct example node compatible string
> - Link to v1: https://lore.kernel.org/r/20240228-imx95-blk-ctl-v1-0-9b5ae3c14d83@nxp.com
> 
> ---
> Peng Fan (6):
>       dt-bindindgs: clock: nxp: support i.MX95 VPU CSR module
>       dt-bindindgs: clock: nxp: support i.MX95 Camera CSR module
>       dt-bindindgs: clock: nxp: support i.MX95 Display Master CSR module
>       dt-bindindgs: clock: nxp: support i.MX95 LVDS CSR module
>       dt-bindindgs: clock: nxp: support i.MX95 Display CSR module
>       clk: imx: add i.MX95 BLK CTL clk driver
> 
>  .../bindings/clock/nxp,imx95-camera-csr.yaml       |  50 +++
>  .../bindings/clock/nxp,imx95-display-csr.yaml      |  50 +++
>  .../clock/nxp,imx95-display-master-csr.yaml        |  62 +++
>  .../bindings/clock/nxp,imx95-lvds-csr.yaml         |  50 +++
>  .../bindings/clock/nxp,imx95-vpu-csr.yaml          |  50 +++
>  drivers/clk/imx/Kconfig                            |   7 +
>  drivers/clk/imx/Makefile                           |   1 +
>  drivers/clk/imx/clk-imx95-blk-ctl.c                | 438 +++++++++++++++++++++
>  include/dt-bindings/clock/nxp,imx95-clock.h        |  32 ++
>  9 files changed, 740 insertions(+)
> ---
> base-commit: c9c32620af65fee2b1ac8390fe1349b33f9d0888
> change-id: 20240228-imx95-blk-ctl-9ef8c1fc4c22
> 
> Best regards,
> -- 
> Peng Fan <peng.fan@....com>
> 
> 
>