Message-ID: <CA+CK2bBTrrJerZMdJrKhg683H4VmnqbgkGu2VG2UuirWNm1TnA@mail.gmail.com>
Date: Sun, 17 Mar 2024 12:15:21 -0400
From: Pasha Tatashin <pasha.tatashin@...een.com>
To: Brian Gerst <brgerst@...il.com>
Cc: "H. Peter Anvin" <hpa@...or.com>, Matthew Wilcox <willy@...radead.org>, 
	Kent Overstreet <kent.overstreet@...ux.dev>, linux-kernel@...r.kernel.org, 
	linux-mm@...ck.org, akpm@...ux-foundation.org, x86@...nel.org, bp@...en8.de, 
	brauner@...nel.org, bristot@...hat.com, bsegall@...gle.com, 
	dave.hansen@...ux.intel.com, dianders@...omium.org, dietmar.eggemann@....com, 
	eric.devolder@...cle.com, hca@...ux.ibm.com, hch@...radead.org, 
	jacob.jun.pan@...ux.intel.com, jgg@...pe.ca, jpoimboe@...nel.org, 
	jroedel@...e.de, juri.lelli@...hat.com, kinseyho@...gle.com, 
	kirill.shutemov@...ux.intel.com, lstoakes@...il.com, luto@...nel.org, 
	mgorman@...e.de, mic@...ikod.net, michael.christie@...cle.com, 
	mingo@...hat.com, mjguzik@...il.com, mst@...hat.com, npiggin@...il.com, 
	peterz@...radead.org, pmladek@...e.com, rick.p.edgecombe@...el.com, 
	rostedt@...dmis.org, surenb@...gle.com, tglx@...utronix.de, urezki@...il.com, 
	vincent.guittot@...aro.org, vschneid@...hat.com
Subject: Re: [RFC 00/14] Dynamic Kernel Stacks

On Sun, Mar 17, 2024 at 10:43 AM Brian Gerst <brgerst@...il.com> wrote:
>
> On Sat, Mar 16, 2024 at 3:18 PM Pasha Tatashin
> <pasha.tatashin@...een.com> wrote:
> >
> > On Thu, Mar 14, 2024 at 11:40 PM H. Peter Anvin <hpa@...or.com> wrote:
> > >
> > > On March 14, 2024 8:13:56 PM PDT, Pasha Tatashin <pasha.tatashin@...een.com> wrote:
> > > >On Thu, Mar 14, 2024 at 3:57 PM Matthew Wilcox <willy@...radead.org> wrote:
> > > >>
> > > >> On Thu, Mar 14, 2024 at 03:53:39PM -0400, Kent Overstreet wrote:
> > > >> > On Thu, Mar 14, 2024 at 07:43:06PM +0000, Matthew Wilcox wrote:
> > > >> > > On Tue, Mar 12, 2024 at 10:18:10AM -0700, H. Peter Anvin wrote:
> > > >> > > > Second, non-dynamic kernel memory is one of the core design decisions in
> > > >> > > > Linux from early on. This means there are lot of deeply embedded assumptions
> > > >> > > > which would have to be untangled.
> > > >> > >
> > > >> > > I think there are other ways of getting the benefit that Pasha is seeking
> > > >> > > without moving to dynamically allocated kernel memory.  One icky thing
> > > >> > > that XFS does is punt work over to a kernel thread in order to use more
> > > >> > > stack!  That breaks a number of things including lockdep (because the
> > > >> > > kernel thread doesn't own the lock, the thread waiting for the kernel
> > > >> > > thread owns the lock).
> > > >> > >
> > > >> > > If we had segmented stacks, XFS could say "I need at least 6kB of stack",
> > > >> > > and if less than that was available, we could allocate a temporary
> > > >> > > stack and switch to it.  I suspect Google would also be able to use this
> > > >> > > API for their rare cases when they need more than 8kB of kernel stack.
> > > >> > > Who knows, we might all be able to use such a thing.
> > > >> > >
> > > >> > > I'd been thinking about this from the point of view of allocating more
> > > >> > > stack elsewhere in kernel space, but combining what Pasha has done here
> > > >> > > with this idea might lead to a hybrid approach that works better; allocate
> > > >> > > 32kB of vmap space per kernel thread, put 12kB of memory at the top of it,
> > > >> > > rely on people using this "I need more stack" API correctly, and free the
> > > >> > > excess pages on return to userspace.  No complicated "switch stacks" API
> > > >> > > needed, just an "ensure we have at least N bytes of stack remaining" API.
> > > >
> > > >I like this approach! I think we could also consider having permanent
> > > >big stacks for some kernel only threads like kvm-vcpu. A cooperative
> > > >stack increase framework could work well and wouldn't negatively
> > > >impact the performance of context switching. However, thorough
> > > >analysis would be necessary to proactively identify potential stack
> > > >overflow situations.
> > > >
> > > >> > Why would we need an "I need more stack" API? Pasha's approach seems
> > > >> > like everything we need for what you're talking about.
> > > >>
> > > >> Because double faults are hard, possibly impossible, and the FRED approach
> > > >> Peter described has extra overhead?  This was all described up-thread.
> > > >
> > > >Handling faults in #DF is possible. It requires code inspection to
> > > >handle race conditions such as what was shown by tglx. However, as
> > > >Andy pointed out, this is not supported by SDM as it is an abort
> > > >context (yet we return from it because of ESPFIX64, so return is
> > > >possible).
> > > >
> > > >My question, however, if we ignore memory savings and only consider
> > > >reliability aspect of this feature.  What is better unconditionally
> > > >crashing the machine because a guard page was reached, or printing a
> > > >huge warning with a backtracing information about the offending stack,
> > > >handling the fault, and survive? I know that historically Linus
> > > >preferred WARN() to BUG() [1]. But, this is a somewhat different
> > > >scenario compared to simple BUG vs WARN.
> > > >
> > > >Pasha
> > > >
> > > >[1] https://lore.kernel.org/all/Pine.LNX.4.44.0209091832160.1714-100000@home.transmeta.com
> > > >
> > >
> > > The real issue with using #DF is that if the event that caused it was asynchronous, you could lose the event.
> >
> > Got it. So, using a #DF handler for stack page faults isn't feasible.
> > I suppose the only way for this to work would be to use a dedicated
> > Interrupt Stack Table (IST) entry for page faults (#PF), but I suspect
> > that might introduce other complications.
> >
> > Expanding on Mathew's idea of an interface for dynamic kernel stack
> > sizes, here's what I'm thinking:
> >
> > - Kernel Threads: Create all kernel threads with a fully populated
> > THREAD_SIZE stack.  (i.e. 16K)
> > - User Threads: Create all user threads with THREAD_SIZE kernel stack
> > but only the top page mapped. (i.e. 4K)
> > - In enter_from_user_mode(): Expand the thread stack to 16K by mapping
> > three additional pages from the per-CPU stack cache. This function is
> > called early in kernel entry points.
> > - exit_to_user_mode(): Unmap the extra three pages and return them to
> > the per-CPU cache. This function is called late in the kernel exit
> > path.
> >
> > Both of the above hooks are called with IRQ disabled on all kernel
> > entries whether through interrupts and syscalls, and they are called
> > early/late enough that 4K is enough to handle the rest of entry/exit.

Hi Brian,

> This proposal will not have the memory savings that you are looking
> for, since sleeping tasks would still have a fully allocated stack.

The tasks that were descheduled while running in user mode should not
increase their stack. The potential saving is greater than the
origianl proposal, because in the origianl proposal we never shrink
stacks after faults.

> This also would add extra overhead to each entry and exit (including
> syscalls) that can happen multiple times before a context switch.  It
> also doesn't make much sense because a task running in user mode will
> quickly need those stack pages back when it returns to kernel mode.
> Even if it doesn't make a syscall, the timer interrupt will kick it
> out of user mode.
>
> What should happen is that the unused stack is reclaimed when a task
> goes to sleep.  The kernel does not use a red zone, so any stack pages
> below the saved stack pointer of a sleeping task (task->thread.sp) can
> be safely discarded.  Before context switching to a task, fully

Excellent observation, this makes Andy Lutomirski per-map proposal [1]
usable without tracking dirty/accessed bits. More reliable, and also
platform independent.

> populate its task stack.  After context switching from a task, reclaim
> its unused stack.  This way, the task stack in use is always fully
> allocated and we don't have to deal with page faults.
>
> To make this happen, __switch_to() would have to be split into two
> parts, to cleanly separate what happens before and after the stack
> switch.  The first part saves processor context for the previous task,
> and prepares the next task.

By knowing the stack requirements of __switch_to(), can't we actually
do all that in the common code in context_switch() right before
__switch_to()? We would do an arch specific call to get the
__switch_to() stack requirement, and use that to change the value of
task->thread.sp to know where the stack is going to be while sleeping.
At this time we can do the unmapping of the stack pages from the
previous task, and mapping the pages to the next task.

> Populating the next task's stack would
> happen here.  Then it would return to the assembly code to do the
> stack switch.  The second part then loads the context of the next
> task, and finalizes any work for the previous task.  Reclaiming the
> unused stack pages of the previous task would happen here.

The problem with this (and the origianl Andy's approach), is that we
cannot sleep here. What happens if we get per-cpu stack cache
exhausted because several threads sleep while having deep stacks? How
can we schedule the next task? This is probably a corner case, but it
needs to have a proper handling solution. One solution is while in
schedule() and while interrupts are still enabled before going to
switch_to() we must pre-allocate 3-page in the per-cpu. However, what
if the pre-allocation itself calls cond_resched() because it enters
page allocator slowpath?

Other than the above concern, I concur, this approach looks to be the
best so far. I will think more about it.

Thank you,
Pasha

[1] https://lore.kernel.org/all/3e180c07-53db-4acb-a75c-1a33447d81af@app.fastmail.com

Powered by blists - more mailing lists