[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b6fecbe4-862c-4ebe-9f56-8514a3c226d4@salutedevices.com>
Date: Sun, 17 Mar 2024 19:39:50 +0300
From: Jan Dakinevich <jan.dakinevich@...utedevices.com>
To: Jerome Brunet <jbrunet@...libre.com>
CC: Neil Armstrong <neil.armstrong@...aro.org>, Michael Turquette
<mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
Kevin Hilman <khilman@...libre.com>, Martin Blumenstingl
<martin.blumenstingl@...glemail.com>, Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
<linux-amlogic@...ts.infradead.org>, <linux-clk@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <alsa-devel@...a-project.org>,
<linux-sound@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
<kernel@...utedevices.com>
Subject: Re: [PATCH 19/25] ASoC: dt-bindings: meson: axg-sound-card: claim
support of A1 SoC family
On 3/15/24 13:06, Jerome Brunet wrote:
>
> On Fri 15 Mar 2024 at 02:21, Jan Dakinevich <jan.dakinevich@...utedevices.com> wrote:
>
>> Add "amlogic,a1-sound-card" compatible string alias to
>> "amlogic,axg-sound-card".
>>
>> Signed-off-by: Jan Dakinevich <jan.dakinevich@...utedevices.com>
>> ---
>> .../devicetree/bindings/sound/amlogic,axg-sound-card.yaml | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml
>> index 5db718e4d0e7..492b41cc8ccd 100644
>> --- a/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml
>> +++ b/Documentation/devicetree/bindings/sound/amlogic,axg-sound-card.yaml
>> @@ -14,7 +14,11 @@ allOf:
>>
>> properties:
>> compatible:
>> - const: amlogic,axg-sound-card
>> + oneOf:
>> + - const: amlogic,axg-sound-card
>> + - items:
>> + - const: amlogic,a1-sound-card
>> + - const: amlogic,axg-sound-card
>
> I know the rule about SoC related name but it is different here.
> This does not describe HW in the SoC.
>
> The axg sound card is just a name, much like simple-card or
> audio-graph-card. I could have named it "amlogic,my-awesome-card"
>
> We would not add "amlogic,a1-simple-card", would we ?
>
> It is purely a software component, which aggregate HW ones.
>
>
>> audio-aux-devs:
>> $ref: /schemas/types.yaml#/definitions/phandle-array
>
>
So, I can drop a couple of commits like this. Right?
--
Best regards
Jan Dakinevich
Powered by blists - more mailing lists