[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5a541ea3-ac4b-4606-9b6a-b103084b30b5@salutedevices.com>
Date: Sun, 17 Mar 2024 17:29:14 +0300
From: Jan Dakinevich <jan.dakinevich@...utedevices.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Neil Armstrong
<neil.armstrong@...aro.org>, Jerome Brunet <jbrunet@...libre.com>, Michael
Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob
Herring <robh@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>, Kevin Hilman <khilman@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Liam Girdwood
<lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Linus Walleij
<linus.walleij@...aro.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
<tiwai@...e.com>, <linux-amlogic@...ts.infradead.org>,
<linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<alsa-devel@...a-project.org>, <linux-sound@...r.kernel.org>,
<linux-gpio@...r.kernel.org>
CC: <kernel@...utedevices.com>
Subject: Re: [PATCH 08/25] ASoC: dt-bindings: meson: g12a-toacodec: add
support for A1 SoC family
I mean the following... This commit adds new defines to
meson-g12a-toacodec.h header. These defines are used in the following way:
sound-dai = <&toacodec TOACODEC_IN_A>;
sound-dai = <&toacodec TOACODEC_CAPTURE_OUT_A>;
So, can you make an advise how to call something like "&toacodec" to
which I declare new parameters.
On 3/15/24 12:58, Krzysztof Kozlowski wrote:
> On 15/03/2024 00:21, Jan Dakinevich wrote:
>> Add "amlogic,t9015-a1" compatible string and new device tree phandle
>> options.
>
> I don't understand the second part. You did not add any options, no
> phandles. You added some defines for something, so say what are these
> "something".
>
>>
>> Signed-off-by: Jan Dakinevich <jan.dakinevich@...utedevices.com>
>> ---
>> .../devicetree/bindings/sound/amlogic,g12a-toacodec.yaml | 1 +
>> include/dt-bindings/sound/meson-g12a-toacodec.h | 5 +++++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
>> index 23f82bb89750..c47604aa590f 100644
>> --- a/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
>> +++ b/Documentation/devicetree/bindings/sound/amlogic,g12a-toacodec.yaml
>> @@ -26,6 +26,7 @@ properties:
>> - items:
>> - enum:
>> - amlogic,sm1-toacodec
>> + - amlogic,a1-toacodec
>
> Keep alphabetical order. Don't stuff new entries to the end...
>
>
>
>
> Best regards,
> Krzysztof
>
--
Best regards
Jan Dakinevich
Powered by blists - more mailing lists