linux-kernel - Re: [PATCH] dt-bindings: iio: health: maxim,max30102: fix compatible check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240317-bakery-numeric-a34b928efa6d@spud>
Date: Sun, 17 Mar 2024 14:37:39 +0000
From: Conor Dooley <conor@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Matt Ranostay <matt@...ostay.sg>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: health: maxim,max30102: fix compatible
 check

On Sat, Mar 16, 2024 at 11:56:57PM +0100, Javier Carrasco wrote:
> The "maxim,green-led-current-microamp" property is only available for
> the max30105 part (it provides an extra green LED), and must be set to
> false for the max30102 part.
> 
> Instead, the max30100 part has been used for that, which is not
> supported by this binding (it has its own binding).
> 
> This error was introduced during the txt to yaml conversion.
> 
> Fixes: 5a6a65b11e3a ("dt-bindings:iio:health:maxim,max30102: txt to yaml conversion")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

> ---
>  Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml b/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> index c13c10c8d65d..eed0df9d3a23 100644
> --- a/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> @@ -42,7 +42,7 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: maxim,max30100
> +            const: maxim,max30102
>      then:
>        properties:
>          maxim,green-led-current-microamp: false
> 
> ---
> base-commit: c1f10ac840caced7a9f717d4170dcc14b3fac076
> change-id: 20240316-max30102_binding_fix-898e7c94cce9
> 
> Best regards,
> -- 
> Javier Carrasco <javier.carrasco.cruz@...il.com>
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)