linux-kernel - Re: [PATCH] drm/xe: Failed getting VMA cause display stuck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZffPt/ww2+/TTMQ+@DUT025-TGLU.fm.intel.com>
Date: Mon, 18 Mar 2024 05:23:03 +0000
From: Matthew Brost <matthew.brost@...el.com>
To: wangxiaoming321 <xiaoming.wang@...el.com>
CC: <lucas.demarchi@...el.com>, <ogabbay@...nel.org>,
	<thomas.hellstrom@...ux.intel.com>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
	<daniel@...ll.ch>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/xe: Failed getting VMA cause display stuck

On Mon, Mar 18, 2024 at 04:43:12AM +0000, Matthew Brost wrote:
> On Mon, Mar 18, 2024 at 12:12:44PM +0800, wangxiaoming321 wrote:
> > The failure of binding VMA is duing to interrupt,
> > So it needs to retry while return fail.
> > 
> > Signed-off-by: wangxiaoming321 <xiaoming.wang@...el.com>
> > ---
> >  drivers/gpu/drm/xe/xe_vm.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> > index 99aa5ffb0ef1..d33476b631e1 100644
> > --- a/drivers/gpu/drm/xe/xe_vm.c
> > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > @@ -2621,6 +2621,9 @@ static int __xe_vma_op_execute(struct xe_vm *vm, struct xe_vma *vma,
> >  	}
> >  	drm_exec_fini(&exec);
> >  
> > +	if (err == -ERESTARTSYS)
> > +		goto retry_userptr;
> 
> This doesn't look right. If the user presses ctrl-c we'd restart?

Typo above. s/restart/retry.

To be clear this patch seems incorrect. This is traced to
dma_fence_wait_timeout, if it is interupted, that function return
-ERESTARTSYS which would should returned to user space via the IOCTL
failing. That is what the exisiting code should be doing.

Matt

> 
> Matt
> 
> > +
> >  	if (err == -EAGAIN) {
> >  		lockdep_assert_held_write(&vm->lock);
> >  
> > -- 
> > 2.25.1
> >