linux-kernel - Re: [RFC] staging: wlan-ng: Driver broken since kernel 5.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <940451c9-cf0b-4be0-9116-80cf7c89a611@app.fastmail.com>
Date: Mon, 18 Mar 2024 09:30:19 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Dan Carpenter" <dan.carpenter@...aro.org>
Cc: "Philipp Hortmann" <philipp.g.hortmann@...il.com>,
 "Lee Jones" <lee@...nel.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
 "Larry Finger" <Larry.Finger@...inger.net>,
 "Johannes Berg" <johannes@...solutions.net>, "Kalle Valo" <kvalo@...nel.org>,
 "Julia Lawall" <julia.lawall@...ia.fr>
Subject: Re: [RFC] staging: wlan-ng: Driver broken since kernel 5.15

On Mon, Mar 18, 2024, at 09:01, Dan Carpenter wrote:
> On Sun, Mar 17, 2024 at 09:20:34PM +0100, Arnd Bergmann wrote:
>> On Sun, Mar 17, 2024, at 21:07, Philipp Hortmann wrote:
>> > On 3/11/24 08:04, Dan Carpenter wrote:
>> >> On Sat, Mar 09, 2024 at 11:09:24PM +0100, Philipp Hortmann wrote:
>> > You are right with the statement that it is this commit.
>> > commit ea82ff749587807fa48e3277c977ff3cec266f25 (HEAD)
>> > Author: Lee Jones <lee.jones@...aro.org>
>> > Date:   Wed Apr 14 19:10:39 2021 +0100
>> >
>> >      staging: wlan-ng: cfg80211: Move large struct onto the heap
>> >
>> >      Fixes the following W=1 kernel build warning(s):
>> >
>> >       drivers/staging/wlan-ng/cfg80211.c: In function ‘prism2_scan’:
>> >       drivers/staging/wlan-ng/cfg80211.c:388:1: warning: the frame size 
>> > of 1296 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>> >
>> > But It is not depending on the line you pointed to.
>> 
>> Right, the kzalloc() already clears the data, so the memset
>> is not needed.
>> 
>
> No, it's inside a loop so it needs to be cleared on each iteration.

Right, at least the conversion could not remove the memset()
without a deeper analysis. It's still likely that each
field of the structure still gets initialized properly
inside the loop and the repeated memset() wasn't necessary
in the first place, but that is a completely separate question.

    Arnd