linux-kernel - Re: [PATCH v2 02/10] xfs: allow xfs_bmapi_convert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZfeYt6zWcX7u1zMG@infradead.org>
Date: Sun, 17 Mar 2024 18:28:23 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Zhang Yi <yi.zhang@...weicloud.com>
Cc: linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, djwong@...nel.org, hch@...radead.org,
	brauner@...nel.org, david@...morbit.com, tytso@....edu,
	jack@...e.cz, yi.zhang@...wei.com, chengzhihao1@...wei.com,
	yukuai3@...wei.com
Subject: Re: [PATCH v2 02/10] xfs: allow xfs_bmapi_convert_delalloc() to pass
 NULL seq

The patch looks good to me:

Reviewed-by: Christoph Hellwig <hch@....de>

But maybe I'd reword the commit message a bit, i.e.:

xfs: make the seq argument to xfs_bmapi_convert_delalloc optional

Allow callers to pass a NULLL seq argument if they don't care about
the fork sequence number.