linux-kernel - Re: [EXTERNAL] Re: [PATCH v11] ASoc: tas2783: Add tas2783 codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89231582-bc4e-4729-8dc1-bac190c28e00@linux.intel.com>
Date: Mon, 18 Mar 2024 10:12:37 +0100
From: Amadeusz Sławiński
 <amadeuszx.slawinski@...ux.intel.com>
To: "Ding, Shenghao" <shenghao-ding@...com>
Cc: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
 "lgirdwood@...il.com" <lgirdwood@...il.com>, "perex@...ex.cz"
 <perex@...ex.cz>,
 "pierre-louis.bossart@...ux.intel.com"
 <pierre-louis.bossart@...ux.intel.com>,
 "13916275206@....com" <13916275206@....com>,
 "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
 "bard.liao@...el.com" <bard.liao@...el.com>,
 "mengdong.lin@...el.com" <mengdong.lin@...el.com>,
 "yung-chuan.liao@...ux.intel.com" <yung-chuan.liao@...ux.intel.com>,
 "Lu, Kevin" <kevin-lu@...com>, "tiwai@...e.de" <tiwai@...e.de>,
 "soyer@....hu" <soyer@....hu>, "Baojun.Xu@....com" <Baojun.Xu@....com>,
 "Navada Kanyana, Mukund" <navada@...com>,
 "broonie@...nel.org" <broonie@...nel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v11] ASoc: tas2783: Add tas2783 codec
 driver

On 3/16/2024 1:44 PM, Ding, Shenghao wrote:
> Thanks for your comments. Kindly see the feedback
> 
>> -----Original Message-----
>> From: Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>
>> Sent: Wednesday, March 6, 2024 12:05 AM
>> To: Ding, Shenghao <shenghao-ding@...com>; broonie@...nel.org
>> Cc: andriy.shevchenko@...ux.intel.com; lgirdwood@...il.com;
>> perex@...ex.cz; pierre-louis.bossart@...ux.intel.com;
>> 13916275206@....com; alsa-devel@...a-project.org; linux-
>> kernel@...r.kernel.org; liam.r.girdwood@...el.com; bard.liao@...el.com;
>> mengdong.lin@...el.com; yung-chuan.liao@...ux.intel.com; Lu, Kevin
>> <kevin-lu@...com>; tiwai@...e.de; soyer@....hu; Baojun.Xu@....com;
>> Navada Kanyana, Mukund <navada@...com>
>> Subject: [EXTERNAL] Re: [PATCH v11] ASoc: tas2783: Add tas2783 codec
>> driver
>>
>> On 3/5/2024 2:26 PM, Shenghao Ding wrote:
>>> The tas2783 is a smart audio amplifier with integrated MIPI SoundWire
>>> interface (Version 1.2.1 compliant), I2C, and I2S/TDM interfaces
>>> designed for portable applications. An on-chip DSP supports Texas
>>> Instruments SmartAmp speaker protection algorithm. The integrated
>>> speaker voltage and current sense provides for real-time monitoring of
>> loudspeakers.
>>>
>>> The ASoC component provides the majority of the functionality of the
>>> device, all the audio functions.
>>>
>>> Signed-off-by: Shenghao Ding <shenghao-ding@...com>
>>>
>>> ---
>>
>> ...
> ...
>>> +struct tasdevice_priv {
>>> +	struct snd_soc_component *component;
>>
>> Apart from being assigned this field seems to be unused.
> This field can help to get the point to "struct tasdevice_priv" in tasdevice_sdw_pcm_hw_free,
> tasdevice_sdw_hw_params, tasdevice_mute
> 

This field is unused in those functions, in all of them you get 
component from dai, via dai->component, and tas_priv from this component 
via snd_soc_component_get_drvdata, which is wrapper around 
dev_get_drvdata, which just returns dev->driver_data.