linux-kernel - Re: [PATCH 00/14] mips: dts: ralink: mt7621: improve DTS style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Mar 2024 10:19:39 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sergio Paracuellos <sergio.paracuellos@...il.com>,
 Justin Swartz <justin.swartz@...ingedge.co.za>
Cc: Arınç ÜNAL <arinc.unal@...nc9.com>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 00/14] mips: dts: ralink: mt7621: improve DTS style

On 18/03/2024 09:48, Sergio Paracuellos wrote:
>>
>>
>>>> But if there're no objections and it lessens the burden on
>>>> maintainers upstream to have less patches to apply, then I have no
>>>> problem combining them into a single patch.
>>>>
>>>
>>> Yeah, one review response instead of 14 responses... One commit in the
>>> history instead of 14.
>>
>> I agree that 1 commit vs 14 is better.
>>
>> But for future reference: is it not enough for the Reviewed-by: trailer
>> to be sent in response to the cover letter of a patch set if a reviewer
>> has looked at the entire set?
> 
> It is enough, AFAICT. I found your patchset very easy to review so I
> am ok with the patchset as it is. However, at the end this will be
> through the mips tree, so let's do what Thomas prefers: add all
> patches as they are or squash all of them in one commit.

Yeah, like fixing language typos in comments: one typo per patch.

Best regards,
Krzysztof