linux-kernel - Re: [PATCH] serial: 8250_lpc18xx: disable clks on error in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 18 Mar 2024 12:22:43 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>,
	Vladimir Zapolskiy <vz@...ia.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_lpc18xx: disable clks on error in probe()

On Mon, Mar 18, 2024 at 12:03:38PM +0200, Andy Shevchenko wrote:
> On Sat, Mar 16, 2024 at 12:30:09PM +0300, Dan Carpenter wrote:
> > Goto the clean up path to clean up a couple clocks before returning
> > on this error path.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> Thank you for fixing this!

Btw, alternatively it may be switched to use devm_clk_get_enabled().

-- 
With Best Regards,
Andy Shevchenko