[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fb9ae93f-9531-468a-b6c8-044b91b62712@collabora.com>
Date: Mon, 18 Mar 2024 11:28:11 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Rafał Miłecki <zajec5@...il.com>,
Matthias Brugger <matthias.bgg@...il.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: Chen-Yu Tsai <wenst@...omium.org>, Hsin-Yi Wang <hsinyi@...omium.org>,
Nícolas F . R . A . Prado <nfraprado@...labora.com>,
Heiko Stuebner <heiko.stuebner@...rry.de>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Chris Morgan <macromorgan@...mail.com>,
Linus Walleij <linus.walleij@...aro.org>, Sean Wang
<sean.wang@...iatek.com>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
linux-kernel@...r.kernel.org, Rafał Miłecki
<rafal@...ecki.pl>
Subject: Re: [PATCH V3 4/4] arm64: dts: mediatek: Add Cudy WR3000 V1
Il 17/03/24 23:32, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@...ecki.pl>
>
> Cudy WR3000 V1 is an MT7981B (AKA Filogic 820) based wireless router. It
> has 256 MiB of RAM, some LEDs & buttons and (not described yet) 4
> Ethernet ports.
>
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
> V2: Reorder properties
> Describe online LED
> V3: Use LED_FUNCTION_WAN_ONLINE (present in torvalds/linux.git)
I'm really happy that you managed to get that WAN_ONLINE definition in the common
leds binding, btw! :-)
>
> arch/arm64/boot/dts/mediatek/Makefile | 1 +
> .../dts/mediatek/mt7981b-cudy-wr3000-v1.dts | 74 +++++++++++++++++++
> 2 files changed, 75 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt7981b-cudy-wr3000-v1.dts
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> index 37b4ca3a87c9..96da4ad640aa 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-evb.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7981b-cudy-wr3000-v1.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7981b-xiaomi-ax3000t.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-acelink-ew-7886cax.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b-cudy-wr3000-v1.dts b/arch/arm64/boot/dts/mediatek/mt7981b-cudy-wr3000-v1.dts
> new file mode 100644
> index 000000000000..54101cc08a25
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b-cudy-wr3000-v1.dts
> @@ -0,0 +1,74 @@
> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> +
> +/dts-v1/;
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> +
> +#include "mt7981b.dtsi"
> +
> +/ {
> + compatible = "cudy,wr3000-v1", "mediatek,mt7981b";
> + model = "Cudy WR3000 V1";
> +
> + memory@...00000 {
> + reg = <0 0x40000000 0 0x10000000>;
> + device_type = "memory";
> + };
> +
> + keys {
> + compatible = "gpio-keys";
> +
> + key-wps {
> + label = "WPS";
> + gpios = <&pio 0 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_WPS_BUTTON>;
> + };
> +
> + key-reset {
> + label = "RESET";
> + gpios = <&pio 1 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_RESTART>;
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led-0 {
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_WAN;
> + gpios = <&pio 5 GPIO_ACTIVE_LOW>;
> + };
> +
> + led-1 {
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_WLAN_2GHZ;
> + gpios = <&pio 6 GPIO_ACTIVE_LOW>;
> + };
> +
> + led-2 {
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_WLAN_5GHZ;
> + gpios = <&pio 7 GPIO_ACTIVE_LOW>;
> + };
> +
> + led-3 {
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_LAN;
> + gpios = <&pio 9 GPIO_ACTIVE_LOW>;
> + };
> +
> + led-4 {
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_STATUS;
> + gpios = <&pio 10 GPIO_ACTIVE_LOW>;
> + };
> +
> + led-5 {
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_WAN_ONLINE;
> + gpios = <&pio 11 GPIO_ACTIVE_LOW>;
> + };
> + };
> +};
Powered by blists - more mailing lists