linux-kernel - Re: [PATCH] mm: Remove guard around pgd_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9341492-cf7b-4c4d-8b6b-2b92b4ecbe74@redhat.com>
Date: Mon, 18 Mar 2024 13:19:39 +0100
From: David Hildenbrand <david@...hat.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm: Remove guard around pgd_offset_k() macro

On 16.03.24 12:52, Christophe Leroy wrote:
> The last architecture redefining pgd_offset_k() was IA64 and it was
> removed by commit cf8e8658100d ("arch: Remove Itanium (IA-64)
> architecture")
> 
> There is no need anymore to guard generic version of pgd_offset_k()
> with #ifndef pgd_offset_k
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> ---
>   include/linux/pgtable.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index 85fc7554cd52..bd9c7180718c 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -149,9 +149,7 @@ static inline pgd_t *pgd_offset_pgd(pgd_t *pgd, unsigned long address)
>    * a shortcut which implies the use of the kernel's pgd, instead
>    * of a process's
>    */
> -#ifndef pgd_offset_k
>   #define pgd_offset_k(address)		pgd_offset(&init_mm, (address))
> -#endif
>   
>   /*
>    * In many cases it is known that a virtual address is mapped at PMD or PTE

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb