linux-kernel - RE: [PATCH] gpiolib: use dev_err when gpiod_configure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB94177BC9D193116C9B4435D0882D2@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date: Mon, 18 Mar 2024 02:03:12 +0000
From: Peng Fan <peng.fan@....com>
To: Andy Shevchenko <andy.shevchenko@...il.com>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>
CC: "linus.walleij@...aro.org" <linus.walleij@...aro.org>, "brgl@...ev.pl"
	<brgl@...ev.pl>, "andy@...nel.org" <andy@...nel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed

> Subject: Re: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed
> 
> On Fri, Mar 15, 2024 at 3:02 AM Peng Fan (OSS) <peng.fan@....nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@....com>
> >
> > Using dev_err to show error message will make life easier.
> 
> dev_err()
> 
> an error
> 
> ...
> 
> It's unclear what the use case is and how this does make life easier.
> We need to know more!

I forgot to add gpio-ranges in gpio node, then it always fail in my driver
probe to configure pinctrl. So if using dev_err(), it will be easier for
me to locate the error point.

Thanks,
Peng.

> 
> --
> With Best Regards,
> Andy Shevchenko