linux-kernel - Re: [PATCH v8 2/8] cpufreq: amd-pstate: Document the units for freq variables in amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ghYCDv2-e0UKXEjSFFbHQ2ingRc1aJco4dSJUknFLadQ@mail.gmail.com>
Date: Mon, 18 Mar 2024 13:35:42 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Perry Yuan <perry.yuan@....com>
Cc: rafael.j.wysocki@...el.com, Mario.Limonciello@....com, 
	viresh.kumar@...aro.org, Ray.Huang@....com, gautham.shenoy@....com, 
	Borislav.Petkov@....com, Alexander.Deucher@....com, Xinmei.Huang@....com, 
	Xiaojian.Du@....com, Li.Meng@....com, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 2/8] cpufreq: amd-pstate: Document the units for freq
 variables in amd_cpudata

On Mon, Mar 18, 2024 at 10:49 AM Perry Yuan <perry.yuan@....com> wrote:
>
> From: "Gautham R. Shenoy" <gautham.shenoy@....com>

No changelog.

> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@....com>

Sender sign-off missing (when sending somebody else's patch, you need
to add your S-o-b tag to it).

> ---
>  include/linux/amd-pstate.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> index 212f377d615b..ab7e82533718 100644
> --- a/include/linux/amd-pstate.h
> +++ b/include/linux/amd-pstate.h
> @@ -51,15 +51,15 @@ struct amd_aperf_mperf {
>   *               priority.
>   * @min_limit_perf: Cached value of the perf corresponding to policy->min
>   * @max_limit_perf: Cached value of the perf corresponding to policy->max
> - * @min_limit_freq: Cached value of policy->min
> - * @max_limit_freq: Cached value of policy->max
> - * @max_freq: the frequency that mapped to highest_perf
> - * @min_freq: the frequency that mapped to lowest_perf
> - * @nominal_freq: the frequency that mapped to nominal_perf
> - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf
> + * @min_limit_freq: Cached value of policy->min (in khz)
> + * @max_limit_freq: Cached value of policy->max (in khz)
> + * @max_freq: the frequency (in khz) that mapped to highest_perf
> + * @min_freq: the frequency (in khz) that mapped to lowest_perf
> + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf
> + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to lowest_nonlinear_perf
>   * @cur: Difference of Aperf/Mperf/tsc count between last and current sample
>   * @prev: Last Aperf/Mperf/tsc count value read from register
> - * @freq: current cpu frequency value
> + * @freq: current cpu frequency value (in khz)
>   * @boost_supported: check whether the Processor or SBIOS supports boost mode
>   * @hw_prefcore: check whether HW supports preferred core featue.
>   *               Only when hw_prefcore and early prefcore param are true,
> --
> 2.34.1
>
>