linux-kernel - Re: [PATCH v2] iio: adc: ad7944: Add support for "3-wire mode"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240318124041.0000032d@Huawei.com>
Date: Mon, 18 Mar 2024 12:40:41 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
CC: David Lechner <dlechner@...libre.com>, Jonathan Cameron
	<jic23@...nel.org>, Michael Hennerich <michael.hennerich@...log.com>, Nuno
 Sá <nuno.sa@...log.com>, <linux-iio@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] iio: adc: ad7944: Add support for "3-wire mode"

> 
> >  struct ad7944_adc {
> >  	struct spi_device *spi;
> > +	enum ad7944_spi_mode spi_mode;
> >  	/* Chip-specific timing specifications. */
> >  	const struct ad7944_timing_spec *timing_spec;
> >  	/* GPIO connected to CNV pin. */
> > @@ -58,6 +75,9 @@ struct ad7944_adc {
> >  	 } sample __aligned(IIO_DMA_MINALIGN);
> >  };  
> 
> Have you run `pahole` to see if there is a better place for a new member?

I know this matters for structures where we see lots of them, but do we actually
care for one offs?  Whilst it doesn't matter here I'd focus much more
on readability and like parameter grouping for cases like this than wasting
a few bytes.

Jonathan