linux-kernel - Re: [PATCH] dt-bindings: nxp,i2c-pnx: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Mar 2024 09:23:24 -0500
From: Rob Herring <robh@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Vladimir Zapolskiy <vz@...ia.com>, Andi Shyti <andi.shyti@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: nxp,i2c-pnx: Convert to dtschema

On Mon, Mar 18, 2024 at 02:49:05PM +0530, Animesh Agarwal wrote:
> Convert the NXP PNX I2C Controller bindings to DT schema.
> Keep only one example in DT schema to remove redundancy.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> ---
>  .../devicetree/bindings/i2c/i2c-pnx.txt       | 34 ------------
>  .../devicetree/bindings/i2c/nxp,i2c-pnx.yaml  | 52 +++++++++++++++++++
>  2 files changed, 52 insertions(+), 34 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-pnx.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml

> diff --git a/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml b/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml
> new file mode 100644
> index 000000000000..b44e4f995b73
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/nxp,i2c-pnx.yaml

Doesn't quite match the compatible string.

> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/nxp,i2c-pnx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP PNX I2C Controller
> +
> +maintainers:
> +  - Animesh Agarwal<animeshagarwal28@...il.com>
> +
> +allOf:
> +  - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: nxp,pnx-i2c
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +

> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0

These 2 are defined in i2c-controller.yaml, so drop.

> +
> +  clock-frequency:
> +    default: 100000
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c1: i2c@...a0000 {

Drop unused labels.

> +        compatible = "nxp,pnx-i2c";
> +        reg = <0x400a0000 0x100>;
> +        interrupt-parent = <&mic>;
> +        interrupts = <51 0>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +    };
> -- 
> 2.44.0
>