linux-kernel - Re: [PATCH] Revert "drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xxjpp3h.fsf@intel.com>
Date: Mon, 18 Mar 2024 16:54:42 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Neil Armstrong <neil.armstrong@...aro.org>, Andrzej Hajda
 <andrzej.hajda@...el.com>, Robert Foss <rfoss@...nel.org>, Laurent
 Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman
 <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David
 Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Luca Weiss
 <luca.weiss@...rphone.com>
Cc: Imre Deak <imre.deak@...el.com>, Ville Syrjälä
 <ville.syrjala@...ux.intel.com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH] Revert "drm/bridge: Select DRM_KMS_HELPER for
 DRM_PANEL_BRIDGE"

On Mon, 18 Mar 2024, Neil Armstrong <neil.armstrong@...aro.org> wrote:
> This reverts commit e3f18b0dd1db242791afbc3bd173026163ce0ccc.
>
> Selecting DRM_KMS_HELPER for DRM_PANEL_BRIDGE leads to:
> WARNING: unmet direct dependencies detected for DRM_KMS_HELPER
>   Depends on [m]: HAS_IOMEM [=y] && DRM [=m]
>   ...
>
> and builds with CONFIG_DRM=m will fail with the above kconfig
> warns and then multiple linker error.
>
> Reported-by: Imre Deak <imre.deak@...el.com>
> Reported-by: Jani Nikula <jani.nikula@...ux.intel.com>
> Reported-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Fixes: e3f18b0dd1db ("drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE")
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>

Acked-by: Jani Nikula <jani.nikula@...el.com>
Tested-by: Jani Nikula <jani.nikula@...el.com>


> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 1d4f010af97b..efd996f6c138 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -8,7 +8,6 @@ config DRM_BRIDGE
>  config DRM_PANEL_BRIDGE
>  	def_bool y
>  	depends on DRM_BRIDGE
> -	select DRM_KMS_HELPER
>  	select DRM_PANEL
>  	help
>  	  DRM bridge wrapper of DRM panels
>
> ---
> base-commit: e3f18b0dd1db242791afbc3bd173026163ce0ccc
> change-id: 20240318-revert-select-drm_kms_helper-for-drm_panel_bridge-0e4ad7c73496
>
> Best regards,

-- 
Jani Nikula, Intel