linux-kernel - Re: [RESEND PATCH v3] x86/apic: Improve data types to fix Coccinelle warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65222aa2-d9a4-48d4-9ddc-2ee519ade4c5@intel.com>
Date: Mon, 18 Mar 2024 09:13:04 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: David.Laight@...LAB.COM, bp@...en8.de, dave.hansen@...ux.intel.com,
 hpa@...or.com, linux-kernel@...r.kernel.org, mingo@...hat.com,
 peterz@...radead.org, tglx@...utronix.de, wei.liu@...nel.org, x86@...nel.org
Subject: Re: [RESEND PATCH v3] x86/apic: Improve data types to fix Coccinelle
 warnings

On 3/18/24 03:47, Thorsten Blum wrote:
> Given that acpi_pm_read_early() returns a u32 (masked to 24 bits), several
> variables that store its return value are improved by adjusting their data
> types from unsigned long to u32. Specifically, change deltapm's type from
> long to u32 because its value fits into 32 bits and it cannot be negative.

Looks, good, thanks for the changes:

Reviewed-by: Dave Hansen <dave.hansen@...ux.intel.com>

I'll put this in the queue.