linux-kernel - Re: [PATCH 2/2] hwmon: pmbus: adp1050 : Add driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8adceac6-9b23-4457-bb9a-8f7e55a581f9@roeck-us.net>
Date: Mon, 18 Mar 2024 09:48:33 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Radu Sabau <radu.sabau@...log.com>, Jean Delvare <jdelvare@...e.com>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>, linux-hwmon@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH 2/2] hwmon: pmbus: adp1050 : Add driver support

On 3/18/24 09:12, Krzysztof Kozlowski wrote:
> On 18/03/2024 12:21, Radu Sabau wrote:
>> Add support for ADP1050 Digital Controller for Isolated Power Supplies
>> with PMBus interface Voltage, Current and Temperature Monitor.
>>
> 
> ...
> 
>> +static int adp1050_probe(struct i2c_client *client)
>> +{
>> +	u32 vin_scale_monitor, iin_scale_monitor;
>> +	int ret;
>> +
>> +	if (!i2c_check_functionality(client->adapter,
>> +				     I2C_FUNC_SMBUS_WRITE_WORD_DATA))
>> +		return -ENODEV;
>> +
>> +	/* Unlock CHIP's password in order to be able to read/write to it's
>> +	 * VIN_SCALE and IIN_SCALE registers.
>> +	*/
>> +	ret = i2c_smbus_write_word_data(client, ADP1050_CHIP_PASSWORD, 0xFFFF);
>> +	if (ret < 0) {
>> +		dev_err_probe(&client->dev, "Device can't be unlocked.\n");
> 
> Syntax is: return dev_err_probe(). Same in other places.
> 

dev_err_probe() expects the error number as second parameter, so I don't
really understand how the above even compiles.

Guenter