linux-kernel - Re: [RFC PATCH v2 0/4] arm64: Add PSCI v1.3 SYSTEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb9215850e8231ab8ef75f523925be671cc6f5a0.camel@infradead.org>
Date: Mon, 18 Mar 2024 17:26:07 +0000
From: David Woodhouse <dwmw2@...radead.org>
To: Marc Zyngier <maz@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, kvm@...r.kernel.org, Paolo Bonzini
 <pbonzini@...hat.com>, Jonathan Corbet <corbet@....net>, Oliver Upton
 <oliver.upton@...ux.dev>, James Morse <james.morse@....com>, Suzuki K
 Poulose <suzuki.poulose@....com>, Zenghui Yu <yuzenghui@...wei.com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Mark Rutland <mark.rutland@....com>, Lorenzo Pieralisi
 <lpieralisi@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown
 <len.brown@...el.com>, Pavel Machek <pavel@....cz>, Mostafa Saleh
 <smostafa@...gle.com>, Jean-Philippe Brucker <jean-philippe@...aro.org>, 
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 kvmarm@...ts.linux.dev,  linux-pm@...r.kernel.org
Subject: Re: [RFC PATCH v2 0/4] arm64: Add PSCI v1.3 SYSTEM_OFF2 support for
 hibernation

On Mon, 2024-03-18 at 16:57 +0000, Marc Zyngier wrote:
> 
> > 
> > There *is* a way for a VMM to opt *out* of newer PSCI versions... by 
> > setting a per-vCPU "special" register that actually ends up setting the 
> > PSCI version KVM-wide. Quite why this isn't just a simple KVM_CAP, I 
> > have no idea.
> 
> Because the expectations are that the VMM can blindly save/restore the
> guest's state, including the PSCI version, and restore that blindly.
> KVM CAPs are just a really bad design pattern for this sort of things.

Hm, am I missing something here? Does the *guest* get to set the PSCI
version somehow, and opt into the latest version that it understands
regardless of what the firmware/host can support?

Because if not, surely it's just part of the basic shape of the
machine, like "how many vCPUs does it have". You don't need to be able
to query it back again. 

I don't think we ever aspired to be able to hand an arbitrary KVM fd to
a userspace VMM and have the VMM be able to drive that VM without
having any a priori context, did we?

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)