linux-kernel - Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Mar 2024 18:34:47 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Ayush Singh <ayushdevel1325@...il.com>,
 Vaishnav M A <vaishnav@...gleboard.org>, devicetree@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-spi@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, lorforlinux@...gleboard.org,
 greybus-dev@...ts.linaro.org
Cc: LKML <linux-kernel@...r.kernel.org>, Alex Elder <elder@...nel.org>,
 Arnd Bergmann <arnd@...db.de>, Conor Dooley <conor+dt@...nel.org>,
 Derek Kiernan <derek.kiernan@....com>, Dragan Cvetic
 <dragan.cvetic@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jason Kridner <jkridner@...gleboard.org>, Johan Hovold <johan@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Mark Brown <broonie@...nel.org>, Nishanth Menon <nm@...com>,
 Rob Herring <robh@...nel.org>, Robert Nelson
 <robertcnelson@...gleboard.org>, Tero Kristo <kristo@...nel.org>,
 Vaishnav M A <vaishnav.a@...com>, Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver

…
> +++ b/drivers/misc/mikrobus/mikrobus_core.c
…
> +static int mikrobus_pinctrl_select(struct mikrobus_port *port,
> +				   const char *pinctrl_selected)
> +{
> +	struct pinctrl_state *state;
> +	int ret;
> +
> +	state = pinctrl_lookup_state(port->pinctrl, pinctrl_selected);
> +	if (IS_ERR(state)) {
> +		return dev_err_probe(&port->dev, PTR_ERR(state),
> +				     "failed to find state %s",
> +				     pinctrl_selected);
> +	}
…

I suggest to reconsider the need for extra curly brackets here.

See also:
Section “3) Placing Braces and Spaces”
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.8#n197


Regards,
Markus