linux-kernel - Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5efc400-8dbc-4aee-9fb5-2993e6830e2c@web.de>
Date: Mon, 18 Mar 2024 19:12:21 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Ayush Singh <ayushdevel1325@...il.com>,
 Vaishnav M A <vaishnav@...gleboard.org>, devicetree@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-spi@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, lorforlinux@...gleboard.org,
 greybus-dev@...ts.linaro.org
Cc: LKML <linux-kernel@...r.kernel.org>, Alex Elder <elder@...nel.org>,
 Arnd Bergmann <arnd@...db.de>, Conor Dooley <conor+dt@...nel.org>,
 Derek Kiernan <derek.kiernan@....com>, Dragan Cvetic
 <dragan.cvetic@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jason Kridner <jkridner@...gleboard.org>, Johan Hovold <johan@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Mark Brown <broonie@...nel.org>, Nishanth Menon <nm@...com>,
 Rob Herring <robh@...nel.org>, Robert Nelson
 <robertcnelson@...gleboard.org>, Tero Kristo <kristo@...nel.org>,
 Vaishnav M A <vaishnav.a@...com>, Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver

…
> +++ b/drivers/misc/mikrobus/mikrobus_core.h
…
> +#ifndef __MIKROBUS_H
> +#define __MIKROBUS_H
…

I suggest to avoid the specification of leading underscores for include guards.

See also:
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29


Regards,
Markus