linux-kernel - Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024031818-lizard-actress-2279@gregkh>
Date: Mon, 18 Mar 2024 19:55:33 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Alex Elder <elder@...e.org>
Cc: Markus Elfring <Markus.Elfring@....de>,
	Ayush Singh <ayushdevel1325@...il.com>,
	Vaishnav M A <vaishnav@...gleboard.org>, devicetree@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-spi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, lorforlinux@...gleboard.org,
	greybus-dev@...ts.linaro.org, LKML <linux-kernel@...r.kernel.org>,
	Alex Elder <elder@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Conor Dooley <conor+dt@...nel.org>,
	Derek Kiernan <derek.kiernan@....com>,
	Dragan Cvetic <dragan.cvetic@....com>,
	Jason Kridner <jkridner@...gleboard.org>,
	Johan Hovold <johan@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Mark Brown <broonie@...nel.org>, Nishanth Menon <nm@...com>,
	Rob Herring <robh@...nel.org>,
	Robert Nelson <robertcnelson@...gleboard.org>,
	Tero Kristo <kristo@...nel.org>, Vaishnav M A <vaishnav.a@...com>,
	Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v4 4/5] mikrobus: Add mikroBUS driver

On Mon, Mar 18, 2024 at 01:41:38PM -0500, Alex Elder wrote:
> On 3/18/24 12:58 PM, Markus Elfring wrote:
> > …
> > > +++ b/drivers/misc/mikrobus/mikrobus_core.c
> > …
> > > +static int mikrobus_pinctrl_setup(struct mikrobus_port *port,
> > > +				  struct addon_board_info *board)
> > > +{
> > > +	int ret;
> > > +
> > > +	if (!board || board->pin_state[MIKROBUS_PIN_PWM] == MIKROBUS_STATE_PWM)
> > > +		ret = mikrobus_pinctrl_select(port, "pwm_default");
> > > +	else
> > > +		ret = mikrobus_pinctrl_select(port, "pwm_gpio");
> > …
> > 
> > How do you think about to avoid the specification of a bit of duplicate source code here
> > by using conditional operator expressions?
> > 
> > 	ret = mikrobus_pinctrl_select(port,
> > 				      ((!board ||
> > 					board->pin_state[MIKROBUS_PIN_PWM] == MIKROBUS_STATE_PWM)
> > 				      ? "pwm_default"
> > 				      : "pwm_gpio"));
> 
> No.
> 
> It's a complex enough bit of logic without trying to bury
> it inside the parameters passed to the function.

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot