linux-kernel - Re: [PATCH v2 3/3] virtio-spi: Add virtio SPI driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfb5092b-ad8f-4364-8655-8f797c428b25@sirena.org.uk>
Date: Tue, 19 Mar 2024 17:11:09 +0000
From: Mark Brown <broonie@...nel.org>
To: Harald Mommer <harald.mommer@...nsynergy.com>
Cc: Haixu Cui <quic_haixcui@...cinc.com>,
	Viresh Kumar <viresh.kumar@...aro.org>, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org, quic_ztu@...cinc.com,
	Matti Moell <Matti.Moell@...nsynergy.com>,
	Mikhail Golubev <Mikhail.Golubev@...nsynergy.com>
Subject: Re: [PATCH v2 3/3] virtio-spi: Add virtio SPI driver.

On Tue, Mar 19, 2024 at 04:05:55PM +0100, Harald Mommer wrote:
> On 18.03.24 10:39, Haixu Cui wrote:

> Looks in my setup like this:
> 
> virtio_mmio@...13000 {
>   compatible = "virtio,mmio";
>   reg = <0x0 0x4b013000 0x0 0x1000>;
>   /* GIC_SPI = 0, IRQ_TYPE_LEVEL_HIGH = 4 */
>   interrupts = <0 497 4>;
>   spi,bus-num = <1234>; /* <<<=== This here has been added */
> };
> 
> The "spi,bus-num" is missing in your setup so you use the default of 0.

The default should be dynamic assignment, why would you need a fixed bus
number?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)