linux-kernel - Re: [PATCH] blk-pm: Remove unnecessary ‘0’ values from ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b460a34-1956-4b24-b044-bc663d4244aa@nvidia.com>
Date: Tue, 19 Mar 2024 03:06:36 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Li zeming <zeming@...china.com>, "axboe@...nel.dk" <axboe@...nel.dk>
CC: "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject:
 Re: [PATCH] blk-pm: Remove unnecessary ‘0’ values from ret

On 3/17/24 20:07, Li zeming wrote:
> ret is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Li zeming <zeming@...china.com>
> ---
>   block/blk-pm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-pm.c b/block/blk-pm.c
> index 42e8420747153..c76d5a3169417 100644
> --- a/block/blk-pm.c
> +++ b/block/blk-pm.c
> @@ -58,10 +58,10 @@ EXPORT_SYMBOL(blk_pm_runtime_init);
>    */
>   int blk_pre_runtime_suspend(struct request_queue *q)
>   {
> -	int ret = 0;
> +	int ret;
>   
>   	if (!q->dev)
> -		return ret;
> +		return 0;
>   
>   	WARN_ON_ONCE(q->rpm_status != RPM_ACTIVE);
>   

I don't see why we need this patch, existing code is fine ...

-ck