linux-kernel - RE: [EXT] Re: [PATCH v5 3/3] arm64: dts: imx93-11x11-evk: add pca9451a support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DB9PR04MB9377B0418D90EE2FCA3414A9E12C2@DB9PR04MB9377.eurprd04.prod.outlook.com>
Date: Tue, 19 Mar 2024 03:20:24 +0000
From: Joy Zou <joy.zou@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Frank Li
	<frank.li@....com>, Jacky Bai <ping.bai@....com>, "lgirdwood@...il.com"
	<lgirdwood@...il.com>, "broonie@...nel.org" <broonie@...nel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC: "kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com"
	<festevam@...il.com>, dl-linux-imx <linux-imx@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [EXT] Re: [PATCH v5 3/3] arm64: dts: imx93-11x11-evk: add
 pca9451a support


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: 2024年3月19日 2:51
> To: Joy Zou <joy.zou@....com>; Frank Li <frank.li@....com>; Jacky Bai
> <ping.bai@....com>; lgirdwood@...il.com; broonie@...nel.org;
> robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> conor+dt@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de
> Cc: kernel@...gutronix.de; festevam@...il.com; dl-linux-imx
> <linux-imx@....com>; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> imx@...ts.linux.dev
> Subject: [EXT] Re: [PATCH v5 3/3] arm64: dts: imx93-11x11-evk: add
> pca9451a support
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 18/03/2024 10:56, Joy Zou wrote:
> > Support pca9451a on imx93-11x11-evk.
> >
> > Signed-off-by: Joy Zou <joy.zou@....com>
> > ---
> > Changes in v5:
> > 1.adjust gpio@22 to the front of pmic@25.
> >
> > Changes in v4:
> > 1. modify the comment for uSDHC but not i2c.
> >
> > Changes in v3:
> > 1. modify the voltages constraints according to the imx93 datasheet.
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 111
> ++++++++++++++++++
> >  1 file changed, 111 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index 9921ea13ab48..478a134d4416 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -183,6 +183,104 @@ &wdog3 {
> >       status = "okay";
> >  };
> >
> > +&lpi2c2 {
> > +     #address-cells = <1>;
> > +     #size-cells = <0>;
> > +     clock-frequency = <400000>;
> > +     pinctrl-names = "default", "sleep";
> > +     pinctrl-0 = <&pinctrl_lpi2c2>;
> > +     pinctrl-1 = <&pinctrl_lpi2c2>;
> > +     status = "okay";
> > +
> > +     pcal6524: gpio@22 {
> > +             compatible = "nxp,pcal6524";
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_pcal6524>;
> > +             reg = <0x22>;
> 
> reg is the second property. Please do not introduce some other coding style.
Yes, will change the reg to the second property.
Thanks for your comments!

BR
Joy Zou
> 
> Best regards,
> Krzysztof