linux-kernel - Re: [PATCH v2] riscv: use KERN_INFO in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37249973-fa73-401e-b5eb-7fd13fc38996@rivosinc.com>
Date: Tue, 19 Mar 2024 12:46:46 -0700
From: Atish Patra <atishp@...osinc.com>
To: Andreas Schwab <schwab@...e.de>, linux-riscv@...ts.infradead.org
Cc: Conor Dooley <conor@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
 Yunhui Cui <cuiyunhui@...edance.com>, Björn Töpel
 <bjorn@...osinc.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] riscv: use KERN_INFO in do_trap

On 3/19/24 08:40, Andreas Schwab wrote:
> Print the instruction dump with info instead of emergency level.  The
> unhandled signal message is only for informational purpose.
> 
> Fixes: b8a03a634129 ("riscv: add userland instruction dump to RISC-V splats")
> Signed-off-by: Andreas Schwab <schwab@...e.de>
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> v2: clarify commit message
> ---
>   arch/riscv/kernel/traps.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
> index a1b9be3c4332..142f5f5168fb 100644
> --- a/arch/riscv/kernel/traps.c
> +++ b/arch/riscv/kernel/traps.c
> @@ -121,7 +121,7 @@ void do_trap(struct pt_regs *regs, int signo, int code, unsigned long addr)
>   		print_vma_addr(KERN_CONT " in ", instruction_pointer(regs));
>   		pr_cont("\n");
>   		__show_regs(regs);
> -		dump_instr(KERN_EMERG, regs);
> +		dump_instr(KERN_INFO, regs);
>   	}
>   
>   	force_sig_fault(signo, code, (void __user *)addr);

Reviewed-by: Atish Patra <atishp@...osinc.com>