linux-kernel - Re: [PATCH v3 04/10] evm: Use the metadata inode to calculate metadata hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90c306c957d0502332bda154ff60f21206c57a3c.camel@linux.ibm.com>
Date: Tue, 19 Mar 2024 18:51:42 -0400
From: Mimi Zohar <zohar@...ux.ibm.com>
To: Stefan Berger <stefanb@...ux.ibm.com>, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-unionfs@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, paul@...l-moore.com, jmorris@...ei.org,
        serge@...lyn.com, roberto.sassu@...wei.com, amir73il@...il.com,
        brauner@...nel.org, miklos@...redi.hu
Subject: Re: [PATCH v3 04/10] evm: Use the metadata inode to calculate
 metadata hash

On Fri, 2024-02-23 at 12:25 -0500, Stefan Berger wrote:
> Changes to file attributes (mode bits, uid, gid) on the lower layer are
> not taken into account when d_backing_inode() is used when a file is
> accessed on the overlay layer and this file has not yet been copied up.
> This is because d_backing_inode() does not return the real inode of the
> lower layer but instead returns the backing inode which in this case
> holds wrong file attributes. Further, when CONFIG_OVERLAY_FS_METACOPY is
> enabled and a copy-up is triggered due to file metadata changes, then
> the metadata are held by the backing inode while the data are still held
> by the real inode. Therefore, use d_inode(d_real(dentry, D_REAL_METADATA))
> to get to the file's metadata inode and use it to calculate the metadata
> hash with.
> 
> Co-developed-by: Mimi Zohar <zohar@...ux.ibm.com>
> Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
> Acked-by: Amir Goldstein <amir73il@...il.com>

Signed-off-by: Mimi Zohar <zohar@...ux.ibm.com>