[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZfoXwW9G6Lr8vKHZ@infradead.org>
Date: Tue, 19 Mar 2024 15:54:57 -0700
From: Christoph Hellwig <hch@...radead.org>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Zhang Yi <yi.zhang@...weicloud.com>, linux-xfs@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
hch@...radead.org, brauner@...nel.org, david@...morbit.com,
tytso@....edu, jack@...e.cz, yi.zhang@...wei.com,
chengzhihao1@...wei.com, yukuai3@...wei.com
Subject: Re: [PATCH v3 3/9] xfs: make xfs_bmapi_convert_delalloc() to
allocate the target offset
> > -xfs_bmapi_convert_delalloc(
> > +static int
>
> static inline?
I'd just leave that to the compiler, no need to second guess all the
decisions.
> Double underscore prefixes read to me like "do this without grabbing
> a lock or a resource", not just one step in a loop.
>
> Would you mind changing it to xfs_bmapi_convert_one_delalloc() ?
> Then the callsite looks like:
Fine with me.
Powered by blists - more mailing lists