[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d6a49d18-51cb-49ad-ba81-b162cb742fb0@linaro.org>
Date: Tue, 19 Mar 2024 06:22:29 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Anjelique Melendez <quic_amelende@...cinc.com>, andersson@...nel.org,
konrad.dybcio@...aro.org, linus.walleij@...aro.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
quic_subbaram@...cinc.com, quic_collinsd@...cinc.com,
quic_jprakash@...cinc.com
Subject: Re: [PATCH 2/5] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIH010x
and PMD802x binding
On 19/03/2024 04:57, Anjelique Melendez wrote:
>
>
> On 3/14/2024 2:20 PM, Krzysztof Kozlowski wrote:
>> On 14/03/2024 21:04, Anjelique Melendez wrote:
>>> Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation
>>> to include compatible strings for PMIH010x and PMD802x PMICs.
>>>
>>> Signed-off-by: Anjelique Melendez <quic_amelende@...cinc.com>
>>> ---
>>> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 20 +++++++++++++++++++
>>> 1 file changed, 20 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
>>> index 2b17d244f051..5cc04c016b25 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
>>> @@ -57,10 +57,12 @@ properties:
>>> - qcom,pma8084-gpio
>>> - qcom,pmc8180-gpio
>>> - qcom,pmc8180c-gpio
>>> + - qcom,pmd802x-gpio
>>
>> Is the "x" some sort of wildcard or actual PMIC model/version name?
>> Wildcards are in general discouraged.
>>
>
> "x" is being used as a wildcard here so can update with actual PMIC version
> in next version.
>
Then please drop it also in all future submissions, as asked by writing
bindings.
Best regards,
Krzysztof
Powered by blists - more mailing lists