[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <de0b32b3-348a-4d42-89cd-df2c439b8009@linaro.org>
Date: Tue, 19 Mar 2024 06:49:32 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: adc128d818: convert to dtschema
On 18/03/2024 21:12, Javier Carrasco wrote:
> Convert adc128d818 bindings to dtschema to support validation.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
Thank you for your patch. There is something to discuss/improve.
> +$id: http://devicetree.org/schemas/hwmon/ti,adc128d818.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments ADC128D818 ADC System Monitor With Temperature Sensor
> +
> +maintainers:
> + - Javier Carrasco <javier.carrasco.cruz@...il.com>
> +
> +description: |
> + The ADC128D818 is a 12-Bit, 8-Channel Analog to Digital Converter (ADC)
> + with a temperature sensor and an I2C interface.
> +
> + Datasheets:
> + https://www.ti.com/product/ADC128D818
> +
> +properties:
> + compatible:
> + const: ti,adc128d818
> +
> + reg:
> + maxItems: 1
> +
> + ti,mode:
You need | to preserve the formatting.
With this:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists