lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9ef61ce3-6f14-4292-9364-903bc52c250d@moroto.mountain>
Date: Tue, 19 Mar 2024 09:17:20 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ayush Tiwari <ayushtiw0110@...il.com>
Cc: Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev, outreachy@...ts.linux.dev
Subject: Re: [PATCH v6] staging: greybus: Constify gb_audio_module_type

On Tue, Mar 19, 2024 at 12:36:25AM +0530, Ayush Tiwari wrote:
> Constify static struct kobj_type gb_audio_module_type to prevent
> modification of data shared across many instances and to address the
> checkpatch warning that "gb_audio_module_type" should be const. The
> "gb_audio_module_type" struct is only used in one place:
> err = kobject_init_and_add(&m->kobj, &gb_audio_module_type, NULL, ...
> so checkpatch is correct that it can be made const.
> 
> Signed-off-by: Ayush Tiwari <ayushtiw0110@...il.com>

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ