linux-kernel - Re: [PATCH 2/4] dt-bindings: media: Add bindings for raspberrypi,rp1-cfe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30430e0e-70de-4831-97ad-974e350a2e54@ideasonboard.com>
Date: Tue, 19 Mar 2024 09:00:00 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Naushir Patuck <naush@...pberrypi.com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Jacopo Mondi <jacopo.mondi@...asonboard.com>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH 2/4] dt-bindings: media: Add bindings for
 raspberrypi,rp1-cfe

On 19/03/2024 08:48, Tomi Valkeinen wrote:
> On 19/03/2024 08:23, Krzysztof Kozlowski wrote:
>> On 18/03/2024 16:49, Tomi Valkeinen wrote:
>>> Add DT bindings for raspberrypi,rp1-cfe.
>>>
>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
>>> ---
>>>   .../bindings/media/raspberrypi,rp1-cfe.yaml        | 103 
>>> +++++++++++++++++++++
>>>   1 file changed, 103 insertions(+)
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml 
>>> b/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml
>>> new file mode 100644
>>> index 000000000000..7b2beeaaab0e
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml
>>> @@ -0,0 +1,103 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/media/raspberrypi,rp1-cfe.yaml#
>>
>> Use compatible as filename.
> 
> Ah, indeed. I changed the compatible quite late, adding the "rpi5" as 
> versioning, and missed changing the file name.
> 
> I'll rename.

Actually, maybe it's better to have two compatibles, 
"raspberrypi,rp1-cfe" as the generic one, and "raspberrypi,rpi5-rp1-cfe" 
(or something similar) for RaspberryPi 5.

And I'm not sure if the "rp1" part is relevant there, would 
"raspberrypi,cfe" be just as fine? Naush?

  Tomi