[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <0ad56d9d-9ba4-40ff-9917-0b71bb530673@linaro.org>
Date: Tue, 19 Mar 2024 10:28:21 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: adc128d818: convert to dtschema
On 19/03/2024 08:01, Javier Carrasco wrote:
> On 3/19/24 06:49, Krzysztof Kozlowski wrote:
>> On 18/03/2024 21:12, Javier Carrasco wrote:
>>> Convert adc128d818 bindings to dtschema to support validation.
>>>
>>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>
>>> +$id: http://devicetree.org/schemas/hwmon/ti,adc128d818.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Texas Instruments ADC128D818 ADC System Monitor With Temperature Sensor
>>> +
>>> +maintainers:
>>> + - Javier Carrasco <javier.carrasco.cruz@...il.com>
>>> +
>>> +description: |
>>> + The ADC128D818 is a 12-Bit, 8-Channel Analog to Digital Converter (ADC)
>>> + with a temperature sensor and an I2C interface.
>>> +
>>> + Datasheets:
>>> + https://www.ti.com/product/ADC128D818
>>> +
>>> +properties:
>>> + compatible:
>>> + const: ti,adc128d818
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + ti,mode:
>>
>> You need | to preserve the formatting.
>>
>
> Thanks, I overlooked that. If I am not mistaken, 2 are still missing
> (ti,mode and vref-supply descriptions).
No, although I commented in a bit wrong place. It should be in
description of ti,mode. Not in vref-supply.
>
> By the way, do you know why dtschema does not complain about that? If I
> place a '|' in a wrong place, it does complain, though.
This is formatting, there is no reason to complain. How would dtschema
understand that you want or not want formatting?
Best regards,
Krzysztof
Powered by blists - more mailing lists