[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b238d70e-0361-4f3c-ae6a-4e6497b95d75@linaro.org>
Date: Tue, 19 Mar 2024 10:50:02 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Manojkiran Eda <manojkiran.eda@...il.com>, patrick.rudolph@...ements.com,
chiawei_wang@...eedtech.com, ryan_chen@...eedtech.com,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
linux-mtd@...ts.infradead.org
Cc: robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, joel@....id.au, andrew@...econstruct.com.au,
miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
jk@...econstruct.com.au, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH v2 3/4] ARM: dts: aspeed: Add eSPI node
On 19/03/2024 10:34, Manojkiran Eda wrote:
> This commit adds eSPI to the device tree for aspeed 5/6th
> generation SoCs.
>
> Signed-off-by: Manojkiran Eda <manojkiran.eda@...il.com>
> ---
> arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 19 +++++++++++++++++++
> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 20 ++++++++++++++++++++
> 2 files changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
> index 04f98d1dbb97..eaf7d82b6f46 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed/aspeed-g5.dtsi
> @@ -343,6 +343,25 @@ sdhci1: sdhci@200 {
> status = "disabled";
> };
> };
> + espi: espi@...ee000 {
spi or syscon
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "aspeed,ast2500-espi", "simple-mfd", "syscon";
> + reg = <0x1e6ee000 0x1000>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x1e6ee000 0x1000>;
> +
> + espi_ctrl: espi-ctrl@0 {
What is this device? If parent is espi, then what is this?
Where is the binding?
Best regards,
Krzysztof
Powered by blists - more mailing lists