linux-kernel - Re: [PATCH v9 0/2] wifi: mwifiex: add code to support host mlme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <969e95ccc4a1d35b45212b7fcb536ee90995e3b5.camel@sipsolutions.net>
Date: Tue, 19 Mar 2024 13:12:30 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Brian Norris <briannorris@...omium.org>, Francesco Dolcini
	 <francesco@...cini.it>
Cc: kvalo@...nel.org, linux-wireless@...r.kernel.org, 
	linux-kernel@...r.kernel.org, David Lin <yu-hao.lin@....com>, 
	tsung-hsien.hsieh@....com, rafael.beims@...adex.com, Francesco Dolcini
	 <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v9 0/2] wifi: mwifiex: add code to support host mlme

On Fri, 2024-03-15 at 17:49 -0700, Brian Norris wrote:
> 
> Now that I've looked a bit closer today: I'm realizing this may(?) be
> one of the first "full MAC" drivers trying to implement its own MLME --
> or at least, the auth/assoc bits.

Hmm, yeah, why _is_ that? mwifiex was originally "sold" as a "full MAC"
driver, i.e. doing things in the firmware.

We've said that "soft MAC" drivers should be using mac80211, but this
thing can't seem to decide?

Also decl.h should probably _shrink_ rather than grow, a number of
things just replicate ieee80211.h (such as MWIFIEX_MGMT_HEADER_LEN
really is just sizeof(ieee80211_mgmt) or so? Not quite correctly.)

So yeah, agree with Brian, not only would this be the first, but it's
also something we don't really _want_. All other drivers that want stuff
like this are stuck in staging ...

So why is this needed for a supposedly "firmware does it all" driver,
and why can it not be integrated with mac80211 if it's no longer
"firmware does it all"?

johannes