[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d1a1b0b8-41f1-4ead-b393-d8d2f099b0c4@acm.org>
Date: Tue, 19 Mar 2024 09:03:45 -0700
From: Bart Van Assche <bvanassche@....org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>,
Mike Christie <michael.christie@...cle.com>,
"James E . J . Bottomley" <jejb@...ux.ibm.com>,
"Martin K . Petersen" <martin.petersen@...cle.com>,
Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: core: Make scsi_lib KUnit tests modular for real
On 3/19/24 05:02, Geert Uytterhoeven wrote:
> While SCSI_LIB_KUNIT_TEST is a tristate config symbol, configuring a
> modular build of this test does not do anything: as the test code is
> just included by the mid layer code, it only works in the built-in case.
>
> Fix this by converting the test to a stand-alone module. This requires
> exporting scsi_check_passthrough() and adding a MODULE_LICENSE() tag.
I don't like it that scsi_check_passthrough() is exported so that counts
as a disadvantage of this patch. Why to convert scsi_lib_test into a
kernel module? What are the advantages compared to the current approach?
That information is missing from the patch description.
Thanks,
Bart.
Powered by blists - more mailing lists