linux-kernel - Re: [PATCH v2] lib/bitmap: Fix bitmap_scatter() and bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZfssQF5MIQSFCaT8@yury-ThinkPad>
Date: Wed, 20 Mar 2024 11:34:40 -0700
From: Yury Norov <yury.norov@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Herve Codina <herve.codina@...tlin.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2] lib/bitmap: Fix bitmap_scatter() and bitmap_gather()
 kernel doc

On Tue, Mar 19, 2024 at 07:33:38PM -0700, Jakub Kicinski wrote:
> On Thu, 14 Mar 2024 13:00:06 +0100 Herve Codina wrote:
> > The make htmldoc command failed with the following error
> >   ... include/linux/bitmap.h:524: ERROR: Unexpected indentation.
> >   ... include/linux/bitmap.h:524: CRITICAL: Unexpected section title or transition.
> > 
> > Move the visual representation to a literal block.
> > 
> > Fixes: de5f84338970 ("lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers")
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Closes: https://lore.kernel.org/linux-kernel/20240312153059.3ffde1b7@canb.auug.org.au/
> > Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> 
> We took the offending commit via netdev, so I feel responsible. Please
> LMK if anyone else is planning to apply this fix, otherwise we'll take
> it and ship it to Linus on Thursday (19th).

Please go ahead and add my

Acked-by: Yury Norov <yury.norov@...il.com>