linux-kernel - Re: [PATCH] staging: nvec: edit udelay comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 20 Mar 2024 12:17:38 -0700
From: Alison Schofield <alison.schofield@...el.com>
To: TaheraFahimi <fahimitahera@...il.com>
Cc: Marc Dietrich <marvin24@....de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	ac100@...ts.launchpad.net, linux-tegra@...r.kernel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: nvec: edit udelay comment

On Fri, Mar 15, 2024 at 03:32:01PM -0600, TaheraFahimi wrote:
> Signed-off-by: TaheraFahimi <fahimitahera@...il.com>

Missing commit log.

Commit message would be clearer like: "correct a misspelled comment"
because when you say you are editing a udelay comment, it made me
think you were clarifying something about usage of udelay.

There are plenty of patches on this list with examples of how
patches of spelling corrections are worded in both the commit
message and log. Please take a look.

Thanks,
Alison


> ---
>  drivers/staging/nvec/nvec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 282a664c9176..b4485b10beb8 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -712,7 +712,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>  	 * TODO: replace the udelay with a read back after each writel above
>  	 * in order to work around a hardware issue, see i2c-tegra.c
>  	 *
> -	 * Unfortunately, this change causes an intialisation issue with the
> +	 * Unfortunately, this change causes an initialisation issue with the
>  	 * touchpad, which needs to be fixed first.
>  	 */
>  	udelay(100);
> -- 
> 2.34.1
> 
>