linux-kernel - Re: [PATCH v6 0/2] Add support for Loongson1 DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJhJPsWN24p8VcLeeB8v_JU6KXTVBzWWcE-Aj4Tc2urqx6sYrw@mail.gmail.com>
Date: Wed, 20 Mar 2024 10:27:21 +0800
From: Keguang Zhang <keguang.zhang@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: Huacai Chen <chenhuacai@...nel.org>, Vinod Koul <vkoul@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-mips@...r.kernel.org, dmaengine@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/2] Add support for Loongson1 DMA

On Wed, Mar 20, 2024 at 1:41 AM Conor Dooley <conor@...nel.org> wrote:
>
> On Tue, Mar 19, 2024 at 10:40:54AM +0800, Huacai Chen wrote:
> > On Tue, Mar 19, 2024 at 10:32 AM Keguang Zhang <keguang.zhang@...il.com> wrote:
> > >
> > > On Mon, Mar 18, 2024 at 11:42 PM Conor Dooley <conor@...nel.org> wrote:
> > > >
> > > > On Mon, Mar 18, 2024 at 10:26:51PM +0800, Huacai Chen wrote:
> > > > > Hi, Conor,
> > > > >
> > > > > On Mon, Mar 18, 2024 at 7:28 PM Conor Dooley <conor@...nel.org> wrote:
> > > > > >
> > > > > > On Mon, Mar 18, 2024 at 03:31:59PM +0800, Huacai Chen wrote:
> > > > > > > On Mon, Mar 18, 2024 at 10:08 AM Keguang Zhang <keguang.zhang@...il.com> wrote:
> > > > > > > >
> > > > > > > > Hi Huacai,
> > > > > > > >
> > > > > > > > > Hi, Keguang,
> > > > > > > > >
> > > > > > > > > Sorry for the late reply, there is already a ls2x-apb-dma driver, I'm
> > > > > > > > > not sure but can they share the same code base? If not, can rename
> > > > > > > > > this driver to ls1x-apb-dma for consistency?
> > > > > > > >
> > > > > > > > There are some differences between ls1x DMA and ls2x DMA, such as
> > > > > > > > registers and DMA descriptors.
> > > > > > > > I will rename it to ls1x-apb-dma.
> > > > > > > OK, please also rename the yaml file to keep consistency.
> > > > > >
> > > > > > No, the yaml file needs to match the (one of the) compatible strings.
> > > > > OK, then I think we can also rename the compatible strings, if possible.
> > > >
> > > > If there are no other types of dma controller on this device, I do not
> > > > see why would we add "apb" into the compatible as there is nothing to
> > > > differentiate this controller from.
> > >
> > > That's true. 1A/1B/1C only have one APB DMA.
> > > Should I keep the compatible "ls1b-dma" and "ls1c-dma"?
> > The name "apbdma" comes from the user manual, "exchange data between
> > memory and apb devices", at present there are two drivers using this
> > naming: tegra20-apb-dma.c and ls2x-apb-dma.c.
>
> I think it's unnessesary but I won't stand in your way.

Then I will follow Huacai's suggestion.
Thanks for your review, Conor and Huacai.

-- 
Best regards,

Keguang Zhang