linux-kernel - Re: [PATCH] acpi: EINJ: mark remove callback as non-_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ivpUuKGx9pW+QeQPSSXNWSSbJwN2oN9p_hmE-nV5VQKA@mail.gmail.com>
Date: Wed, 20 Mar 2024 21:00:55 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Dan Williams <dan.j.williams@...el.com>
Cc: Arnd Bergmann <arnd@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Jonathan Cameron <Jonathan.Cameron@...wei.com>, Ben Cheatham <Benjamin.Cheatham@....com>, 
	Arnd Bergmann <arnd@...db.de>, Len Brown <lenb@...nel.org>, James Morse <james.morse@....com>, 
	Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>, Avadhut Naik <Avadhut.Naik@....com>, 
	Shuai Xue <xueshuai@...ux.alibaba.com>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acpi: EINJ: mark remove callback as non-__exit

On Wed, Mar 20, 2024 at 8:58 PM Dan Williams <dan.j.williams@...el.com> wrote:
>
> Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > The remove callback of a device is called whenever it is unbound,
> > which may happen during runtime e.g. through sysfs, so this is not
> > allowed to be dropped from the binary:
> >
> > WARNING: modpost: vmlinux: section mismatch in reference: einj_driver+0x8 (section: .data) -> einj_remove (section: .exit.text)
> > ERROR: modpost: Section mismatches detected.
> >
> > Remove that annotation.
>
> Looks good, not sure why the build robots missed this while this was
> sitting in -next. Yes, this was a side effect of reusing the former
> einj_exit() as the device remove callback.
>
> Reviewed-by: Dan Williams <dan.j.williams@...el.com>
>
> Rafael, can you pick this up?

I will, thanks!