[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZftH2ArlSkt4kX7M@smile.fi.intel.com>
Date: Wed, 20 Mar 2024 22:32:24 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Sui Jingfeng <sui.jingfeng@...ux.dev>, David Airlie <airlied@...il.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org,
Sui Jingfeng <suijingfeng@...ngson.cn>
Subject: Re: [PATCH 5/5] drm-bridge: display-connector: Switch to use fwnode
API
On Tue, Jan 23, 2024 at 03:20:26AM +0200, Laurent Pinchart wrote:
> On Tue, Jan 23, 2024 at 12:32:20AM +0800, Sui Jingfeng wrote:
..
> > conn->bridge.of_node = pdev->dev.of_node;
> > + conn->bridge.fwnode = pdev->dev.fwnode;
>
> This goes in the right direction. Let's address the other drivers and
> drop the OF-based calls in the same series :-)
+1. BUT, please use device_set_node() instead of both lines.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists