linux-kernel - Re: [PATCH net v1] mlxbf_gige: stop PHY during open() error paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e21ceae-e889-4177-8397-9df250ba558d@lunn.ch>
Date: Wed, 20 Mar 2024 23:34:56 +0100
From: Andrew Lunn <andrew@...n.ch>
To: David Thompson <davthompson@...dia.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, u.kleine-koenig@...gutronix.de, leon@...nel.org,
	asmaa@...dia.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v1] mlxbf_gige: stop PHY during open() error paths

On Wed, Mar 20, 2024 at 03:31:17PM -0400, David Thompson wrote:
> The mlxbf_gige_open() routine starts the PHY as part of normal
> initialization.  The mlxbf_gige_open() routine must stop the
> PHY during its error paths.
> 
> Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
> Signed-off-by: David Thompson <davthompson@...dia.com>
> Reviewed-by: Asmaa Mnebhi <asmaa@...dia.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew