[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240320073344.1563102-1-peng.fan@oss.nxp.com>
Date: Wed, 20 Mar 2024 15:33:44 +0800
From: "Peng Fan (OSS)" <peng.fan@....nxp.com>
To: linus.walleij@...aro.org,
brgl@...ev.pl,
andy@...nel.org
Cc: linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org,
Peng Fan <peng.fan@....com>
Subject: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags failed
From: Peng Fan <peng.fan@....com>
When gpio-ranges property was missed to be added in the gpio node,
using dev_err() to show an error message will helping to locate issues
easier.
Signed-off-by: Peng Fan <peng.fan@....com>
---
V2:
Update commit log
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index ce94e37bcbee..37fe9db0bd74 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -4233,7 +4233,7 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
if (ret < 0) {
- dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
+ dev_err(consumer, "setup of GPIO %s failed: %d\n", con_id, ret);
gpiod_put(desc);
return ERR_PTR(ret);
}
--
2.37.1
Powered by blists - more mailing lists