linux-kernel - Re: [PATCH] media: mediatek: vcodec: Handle invalid decoder vsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 20 Mar 2024 10:13:42 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Irui Wang <irui.wang@...iatek.com>,
 Hans Verkuil <hverkuil-cisco@...all.nl>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 Yunfei Dong <yunfei.dong@...iatek.com>, nicolas.dufresne@...labora.com,
 sebastian.fricke@...labora.com
Cc: Longfei Wang <longfei.wang@...iatek.com>,
 Maoguang Meng <maoguang.meng@...iatek.com>,
 Project_Global_Chrome_Upstream_Group@...iatek.com,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] media: mediatek: vcodec: Handle invalid decoder vsi

Il 20/03/24 07:13, Irui Wang ha scritto:
> Handle invalid decoder vsi in vpu_dec_init to ensure the decoder vsi is
> valid for future use.
> 
> Signed-off-by: Irui Wang <irui.wang@...iatek.com>

This commit needs a Fixes tag, can you please add the relevant one and resend?

Thanks,
Angelo

> ---
>   .../media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c    | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c
> index 82e57ae983d5..17770993fe5a 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c
> @@ -231,6 +231,12 @@ int vpu_dec_init(struct vdec_vpu_inst *vpu)
>   	mtk_vdec_debug(vpu->ctx, "vdec_inst=%p", vpu);
>   
>   	err = vcodec_vpu_send_msg(vpu, (void *)&msg, sizeof(msg));
> +
> +	if (IS_ERR_OR_NULL(vpu->vsi)) {
> +		mtk_vdec_err(vpu->ctx, "invalid vdec vsi, status=%d", err);
> +		return -EINVAL;
> +	}
> +
>   	mtk_vdec_debug(vpu->ctx, "- ret=%d", err);
>   	return err;
>   }